add new permissions from android API 31#1642
Open
tomaszduda23 wants to merge 1 commit intohbldh:developfrom
Open
add new permissions from android API 31#1642tomaszduda23 wants to merge 1 commit intohbldh:developfrom
tomaszduda23 wants to merge 1 commit intohbldh:developfrom
Conversation
Collaborator
|
We've been discussing this in #1621. My preference would be to move this to a separate function in addition to adding the require permissions for newer Android versions. |
Author
done |
dlech
reviewed
Oct 5, 2024
Collaborator
|
Also, we will need a changelog entry explaining that this is a breaking change. |
Author
|
updated according to review notes |
tomaszduda23
force-pushed
the
develop
branch
2 times, most recently
from
f72cd38 to
1d556f1
Compare
Author
|
github action should have started itself after pushing new version. It takes way to much time to fix all lint. |
Collaborator
|
Don't worry about the linting, I can fix it when I get back to this. |
Author
|
any chance to get it merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Guidelines for Bleak
Before you submit a pull request, check that it meets these guidelines:
CHANGELOG.rst, describing your changes as is specified by theguidelines in that document.
different problems and you are committing them in the same PR. In that case,
consider making several PRs instead.
AUTHORS.rstfile!